Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace awesome_print with amazing_print #8

Merged
merged 2 commits into from
Jul 7, 2020
Merged

replace awesome_print with amazing_print #8

merged 2 commits into from
Jul 7, 2020

Conversation

jsvd
Copy link
Member

@jsvd jsvd commented Jul 7, 2020

the awesome_print library has become inactive and fixes weren't being released, so this PR switches to a new fork called amazing_print!

This will remove the current warning whenever this codec is used for the first time:

The stdin plugin is now waiting for input:
er
/private/tmp/logstash-7.8.0/vendor/bundle/jruby/2.5.0/gems/awesome_print-1.7.0/lib/awesome_print/formatters/base_formatter.rb:31: warning: constant ::Fixnum is deprecated
{
          "type" => "stdin",
       "message" => "er",
      "@version" => "1",
    "@timestamp" => 2020-07-07T10:28:22.493Z,
          "host" => "joaos-mbp.lan"
}

@elasticsearch-bot elasticsearch-bot self-assigned this Jul 7, 2020
Copy link

@kares kares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 wanted to "fix" this for so long

@jsvd jsvd merged commit 60e5ad2 into master Jul 7, 2020
@jsvd jsvd deleted the amazing_print branch July 7, 2020 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants