Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle split reads #6

Closed
wants to merge 2 commits into from
Closed

Handle split reads #6

wants to merge 2 commits into from

Conversation

doubret
Copy link

@doubret doubret commented Mar 19, 2015

Handle split reads when used with tcp input for exemple.
I replaced input buffer processing with BufferedTokenizer to handle the case when a line is not read completely.
Also, i strip the carriage return if any so that the grok can work correctly.

doubret added 2 commits March 19, 2015 10:35
Handle split reads when used with tcp input.
Added missing require for BufferedTokenizer
@elasticsearch-release
Copy link

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

@guyboertje
Copy link
Contributor

@doubret - I'm sorry for not picking up this PR sooner.
This codec is going through some big changes at the moment, and the code now is not as it was when you branched.

Further, I do not believe that this codec needs this modification. Its stated goal and whole reason for being is to gather multiple lines that belong together into one event. Note the emphasis on lines - meaning that the upstream source of data really should honour this "contract" and feed this codec whole lines.
After all Its only the upstream source that "knows" about the structure and format of the data that it is receiving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants