Allow disabling splitting original message to lines #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'. |
7283f0d to
809049f
Compare
Added split_original config param (default: true), when true - splits the original message to multiple lines by '\n'; when false - passes original message as is. over_maximun_lines check changed from 'greater then' to 'greater or equal': setting max_lines = X actually produced message blocks of X+1 messages due to strict "greater than" sign.
|
Could this be merged? |
|
any update? |
|
@sxmichael Sorry for the very long delays. I don't understand what problem this code is solving. Multiline is a line-oriented concept, so splitting by line on the input payload makes sense to me (example: tcp input can read large chunks of text that include multiple, possibly unrelated, lines). Your example of ES bulk api isn't clear enough to me to understand what you need. Can you tell me a story or describe a use case? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it's necessary to join multiple messages from the input, without splitting the original message by new lines (example: joining es bulk api input messages)