Add missing "dvcmac" => "deviceMacAddress" field. #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test cases from pull request #51 need to be adjusted to include this new field. I will wait for the finalization of that integration and then update the test cases. |
|
hey @fchouina this could use a changelog entry and version bump. still up for it? |
|
This was included in #88 and has been available since version 6.2.1 of this plugin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose the addition of the following missing field that is present in the CEF specifications document:
dvcmac => deviceMacAddress
Since this will inevitably change the behavior of the codec that ignored this field until now, I have followed Collin's suggestion and put this in its own pull request.