Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMRNAV-3826 Fix for nav2_velocity_smoother #8

Merged
merged 3 commits into from
Jan 13, 2023

Conversation

HovorunB
Copy link

@HovorunB HovorunB commented Jan 9, 2023


Basic Info

Info Fix for nav2_velocity_smoother
Ticket(s) this addresses (add tickets here #1)
Primary OS tested on (Ubuntu, MacOS, Windows)
Robotic platform tested on (Steve's Robot, gazebo simulation of Tally, hardware turtlebot)

Related deep_cv PR: https://github.com/logivations/deep_cv/pull/4793

Description of contribution in a few bullet points

  • Added condition to fix an error when using sim time

Screenshot from 2023-01-09 08-37-25


For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@HovorunB HovorunB added the bug Something isn't working label Jan 9, 2023
@HovorunB HovorunB requested a review from tonynajjar January 9, 2023 07:49
@HovorunB HovorunB self-assigned this Jan 9, 2023
@tonynajjar
Copy link

Can you please clarify to me how the condition being none contributes to command_ being null? command_ is not in the condition

@HovorunB
Copy link
Author

HovorunB commented Jan 9, 2023

Can you please clarify to me how the condition being none contributes to command_ being null? command_ is not in the condition

If we use sim time the condition is false on startup. And if the condition is false we proceed to access command_'s properties which leads to an error since command_ is a nullptr on startup

Copy link

@tonynajjar tonynajjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix like it was fixed in upstream

@HovorunB HovorunB merged commit 2e79f94 into humble Jan 13, 2023
@HovorunB HovorunB deleted the AMRNAV-3826_smoother_driving branch January 13, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants