Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/POD 1270 deleted pro workspace shows up in cli #1579

Conversation

pascalbreuninger
Copy link
Member

  • fix(cli): synchronize deleted pro workspace with remote state by comparing local response vs remote instances
  • chore(cli): improve list command with multiple pro providers

by comparing local response vs remote instances

Cleans up orphaned local workspace files if necessary
@pascalbreuninger pascalbreuninger requested a review from a team January 20, 2025 13:02
@pascalbreuninger pascalbreuninger force-pushed the fix/POD-1270-deleted-pro-workspace-shows-up-in-cli branch from c774907 to 09103b6 Compare January 20, 2025 13:23
Copy link
Contributor

@bkneis bkneis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit and a Q

pkg/workspace/list.go Show resolved Hide resolved
@pascalbreuninger pascalbreuninger force-pushed the fix/POD-1270-deleted-pro-workspace-shows-up-in-cli branch 2 times, most recently from 6fc6846 to 2dbe2bb Compare January 20, 2025 14:14
@pascalbreuninger pascalbreuninger force-pushed the fix/POD-1270-deleted-pro-workspace-shows-up-in-cli branch from 2dbe2bb to a9606b8 Compare January 20, 2025 15:50
@pascalbreuninger pascalbreuninger merged commit 60b0947 into loft-sh:main Jan 20, 2025
17 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants