Add support for VSCode based IDE inside Flatpak #1577
+169
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a442ad7 to
59cb805
Compare
59cb805 to
cd4654f
Compare
| Name: config.IDECodiumInsiders, | ||
| DisplayName: "Codium Insiders", | ||
| Options: vscode.Options, | ||
| Icon: "https://devpod.sh/assets/codium_insiders.svg", // TODO to be uploaded |
There was a problem hiding this comment.
This is available now, you can remove the TODO :)
| @@ -24,5 +24,6 @@ const ( | |||
| IDEPositron IDE = "positron" | |||
| IDEMarimo IDE = "marimo" | |||
| IDECodium IDE = "codium" | |||
| IDECodiumInsiders IDE = "codium-insiders" | |||
There was a problem hiding this comment.
We'll have to expose this in DevPod Desktop as well, will create a follow up PR
pkg/ide/vscode/open.go
Outdated
| return fmt.Errorf("couldn't find the %s binary", flavor) | ||
| } | ||
|
|
||
| if codePath[0] == "flatpak" { | ||
| log.Debugf("Running with Flatpak suing the package %s.", codePath[2]) |
There was a problem hiding this comment.
nitpick:
Suggested change
| log.Debugf("Running with Flatpak suing the package %s.", codePath[2]) | |
| log.Debugf("Running with Flatpak using the package %s.", codePath[2]) |
| log.Warnf("The IDE is already running via Flatpak. If you are encountering SSH connectivity issues, make sure to give read access to your SSH config file (e.g flatpak override %s --filesystem=%s) and restart your IDE.", codePath[2], sshConfigPath) | ||
| } | ||
|
|
||
| codePath = slices.Insert(codePath, 2, fmt.Sprintf("--filesystem=%s:ro", sshConfigPath)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for VSCode based IDE installed via Flatpak on Linux. Note that this depends on a limitation in
open-remote-sshNote: this is also adding support for Codium Insiders. Let me know if you want me to split the commit or PR