Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devcontainer): use the default shell on Windows for initalizeCommand #1552

Merged
merged 1 commit into from
Jan 14, 2025
Merged

fix(devcontainer): use the default shell on Windows for initalizeCommand #1552

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion pkg/devcontainer/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,11 +208,23 @@ func runInitializeCommand(
return nil
}

shellArgs := []string{"sh", "-c"}
// According to the devcontainer spec, `initializeCommand` needs to be run on the host.
// On Windows we can't assume everyone has `sh` added to their PATH so we need to use Windows default shell (usually cmd.exe)
if runtime.GOOS == "windows" {
comSpec := os.Getenv("COMSPEC")
if comSpec != "" {
shellArgs = []string{comSpec, "/c"}
} else {
shellArgs = []string{"cmd.exe", "/c"}
}
}

for _, cmd := range config.InitializeCommand {
// should run in shell?
var args []string
if len(cmd) == 1 {
args = []string{"sh", "-c", cmd[0]}
args = []string{shellArgs[0], shellArgs[1], cmd[0]}
} else {
args = cmd
}
Expand Down
Loading