Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base 64 encode and decode signing key #1496

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

bkneis
Copy link
Contributor

@bkneis bkneis commented Dec 19, 2024

Fixes #1438

Not sure how to test this one. I ran up using the problematic workspace and could SSH and use my git credentials. But since my signing key doesn't cause an issue I can't replicate. But I can confirm the base64 decode / encode works

@bkneis bkneis requested a review from a team December 19, 2024 09:44
Copy link
Member

@pascalbreuninger pascalbreuninger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pascalbreuninger pascalbreuninger merged commit 5508a24 into loft-sh:main Dec 19, 2024
17 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Starting container with --debug prints repeating fatal error
2 participants