Distribute package as a universal wheel #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wheels are the new standard of python distribution. Advantages of wheels includes: - Faster installation - Avoids arbitrary code execution for installation by avoiding setup.py - Allows better caching for testing and continuous integration - Creates .pyc files as part of installation to ensure they match the python interpreter used - More consistent installs across platforms and machines As locust is a pure Python package (no C files) for both Python 2 & 3, the wheel can be distributed as universal. When you wouldd normally run `python setup.py sdist upload`, run instead `python setup.py sdist bdist_wheel upload`. The wheel includes the LICENSE file through the [metadata] attribute license_file. For additional information on Python wheels, see: https://pythonwheels.com/ For the detailed PEP, see: https://www.python.org/dev/peps/pep-0427/
Codecov Report
@@ Coverage Diff @@
## master #756 +/- ##
=======================================
Coverage 65.13% 65.13%
=======================================
Files 14 14
Lines 1417 1417
Branches 222 222
=======================================
Hits 923 923
Misses 443 443
Partials 51 51Continue to review full report at Codecov.
|
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wheels are the new standard of Python distribution. Advantages of wheels includes:
setup.py.pycfiles as part of installation to ensure they match thepython interpreter used
As locust is a pure Python package (no C files) for both Python 2 & 3, the wheel can be distributed as universal.
When you wouldd normally run
python setup.py sdist upload, run insteadpython setup.py sdist bdist_wheel upload.The wheel includes the
LICENSEfile through the[metadata]attributelicense_file.For additional information on Python wheels, see:
https://pythonwheels.com/
For the detailed PEP, see:
https://www.python.org/dev/peps/pep-0427/