Make internal server error new fallback error type

[georgeboot]

Currently, all errors become a 400 Bad Request, unless an explicit error type is set. This is not ideal, as a bad request should not be retried by a client since it's the client that is at fault (as is for al 4xx codes). A better generic 'fallback' error would be a 500 internal server error, as it indicates something went wrong, and sending another attempt might very well succeed.

This pull requests changes the currenty behaviour by returning a 500 on all non-explicit errors.

[kaplanelad]

We already have an InternalServer enum in this match. Replace the INTERNAL_SERVER_ERROR variant with InternalServerError.

[georgeboot]

Apologies for the oversight. Fixed

[kaplanelad]

why did you changed the response?

[georgeboot]

why did you changed the response?

I had to implement the bad request error which carries a reason, and then saw that internal server error had some sort of enum style error message and the same but formatted in the description, so figured it was probably prototyped and never fully implemented, so I did it.

[kaplanelad]

This is the original response

ErrorDetail::new("internal_server_error", "Internal Server Error"),

Why did you change it?

[georgeboot]

I had to implement the bad request error which carries a reason, and then saw that internal server error had some sort of enum style error message and the same but formatted in the description, so figured it was probably prototyped and never fully implemented, so I added the change to this PR. Happy to submit it in another PR if you like.

[kaplanelad]

The 500 responses should follow this format:

{
    "error":"internal_server_error",
    "description":"Internal Server Error"
}

instead of the format you changed it to:

{
    "error":"Internal Server Error"
}

[georgeboot]

But why the specific format though? The error message looks very arbitrary, the description contains the same as the error itself, where other error types don't have that. The HTTP error code already communicates the error variant for matching, so the body does not need to machine readable. Or am I missing something?

[kaplanelad]

I believe all errors should follow this format, as it provides a clear, standardized error code for API responses.

[georgeboot]

Cool, will update