-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds rf_render_png and rf_rgb_composite. #301
Conversation
* fix/295: Reenabled test (mostly) covered by 242. Fix for columnar functions which accept `Tile` or `ProjectedRasterTile`, but claimed all return values were `Tile`. This was problematic whenever the `Tile` as reified, and the serialization of `ProjectedRasterTile` confused the `Tile` deserializer. Updated copyright in template. Update LICENSE
* develop: Expressions returning primitives can't return `null`, so changing how constant tiles are created to keep catalyst optimizer from pruning them. Added tests for rf_convert_cell_type and rf_with_no_data. Fixed a bug with counting data/no_data cells on constant tiles. Additional fixes for issue locationtech#242 that cropped back up. Bump python development version to match JVM version # Conflicts: # core/src/main/scala/org/locationtech/rasterframes/ref/RasterRef.scala # core/src/main/scala/org/locationtech/rasterframes/tiles/ProjectedRasterTile.scala # pyrasterframes/src/main/python/tests/RasterFunctionsTests.py
* develop: Add ignored test from stale branch mm m a Time series doc reorg vector filtering time series park geojson filepath variabl ci tweak to get error markdown Attempt to save markdown artifacts on failed docs build. Attempt to save markdown artifacts on failed docs build. Tweak partitions Add folium to setup / requirements DataFrame API only, folium display of temp file Add failing unit test for rf_explode_tiles_resample
* develop: Fixed table rendering test. Misc tweaks to address PR feedback. Added ellipsis to truncated table cells in Markdown and HTML renderers. Bug was with changes to `rf_with_no_data` acceptance of either `Double` or `Int`, and then incorrectly changing floating point tiles into a float cell type. Fixes locationtech#304. Updated ShowableTile to render NoData values differently. Moved array function tests to RasterFunctionsSpec. Remove last running example from function ref page Update rendered notebook results with new ipython display integration # Conflicts: # docs/src/main/paradox/release-notes.md
Signed-off-by: Jason T. Brown <jason@astraea.earth>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main thing is to check the clamp
thing is intended and all good.
I would like to see a column function for single tile color ramp to png in python. Not sure how useful it is but just to keep parity.
We should also revisit the notebook about rendering things. We may be able to remove the notebook if we do as you mentioned creating a page about exploring the data?
core/src/main/scala/org/locationtech/rasterframes/RasterFunctions.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/locationtech/rasterframes/ref/RasterSource.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/locationtech/rasterframes/util/DataFrameRenderers.scala
Show resolved
Hide resolved
core/src/main/scala/org/locationtech/rasterframes/util/DataFrameRenderers.scala
Show resolved
Hide resolved
core/src/main/scala/org/locationtech/rasterframes/expressions/package.scala
Show resolved
Hide resolved
I'd like to have the rendered docs be fully self-contained/complete, so I'm in favor of that being a goal. Another way of thinking about it is we could have a dedicated "Jupyter" chapter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also remove the static table on the description.md
page in favor of generating one so that it will be styled consistently with other displayed tables (looking ahead a bit to #308 here)
|
No description provided.