Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RasterJoin error on LHS projected raster tile #419

Closed
vpipkt opened this issue Nov 15, 2019 · 1 comment · Fixed by #420
Closed

RasterJoin error on LHS projected raster tile #419

vpipkt opened this issue Nov 15, 2019 · 1 comment · Fixed by #420
Labels
bug When it really isn't a "feature".

Comments

@vpipkt
Copy link
Member

vpipkt commented Nov 15, 2019

No description provided.

@vpipkt vpipkt added the bug When it really isn't a "feature". label Nov 15, 2019
@metasim
Copy link
Member

metasim commented Nov 15, 2019 •
edited
Loading

Doesn't automatically coerce proj_raster to tile, which is needed due to use of UDF to do the merging operation.

Third column needs rf_tile added to it:

rasterframes/core/src/main/scala/org/locationtech/rasterframes/extensions/RasterJoin.scala

Line 79 in 9de8ebc

col(leftExtent2), col(leftCRS2), col(t.columnName), col(rightExtent2), col(rightCRS2), rf_dimensions(unresolved(leftTile))

metasim added a commit to s22s/rasterframes that referenced this issue Nov 18, 2019
@metasim
Added the ability to do a raster_join on proj_raster types.
9385136 
Fixes locationtech#419.
@metasim metasim mentioned this issue Nov 18, 2019
Merged
metasim added a commit to s22s/rasterframes that referenced this issue Nov 19, 2019
@metasim
Merge branch 'develop' into astraea/release
9a24f08 
* develop: (79 commits)
  remove unused imports
  Python unit tests check read pipeline stages
  Cruft removal.
  Fix for ML transformer read/write
  Add failing unit tests for issue 425 ML custom transformer loading is broken
  PR feedback.
  Fixed `ReprojectToLayer` to work with `proj_raster`. Closes locationtech#357 Depends on locationtech#420.
  break out commented assert into skipped unit test around masking and deserialization
  register rf_local_extract_bit with SQL functions
  Added the ability to do a raster_join on proj_raster types. Fixes locationtech#419.
  Add landsat masking section to masking docs page
  Add mask bits  python api and unit test
  Extract bits should throw on non-integral cell types
  Fix for both masking by def and value; expand code comments; update tests
  Python regression.
  Masking improvements and unit tests.
  Regression
  Added (disabled) integration test for profiling spatial index effects. Reorganized non-evaluated documentationm files to `docs`.
  Add failing unit test for mask by value on 0
  Updated python tests against spatial index functions.
  ...
metasim added a commit to s22s/rasterframes that referenced this issue Nov 22, 2019
@metasim
Merge branch 'develop' into feature/gt-3.0
d223b82 
* develop: (24 commits)
  remove unused imports
  Python unit tests check read pipeline stages
  Cruft removal.
  Fix for ML transformer read/write
  Add failing unit tests for issue 425 ML custom transformer loading is broken
  PR feedback.
  Fixed `ReprojectToLayer` to work with `proj_raster`. Closes locationtech#357 Depends on locationtech#420.
  break out commented assert into skipped unit test around masking and deserialization
  register rf_local_extract_bit with SQL functions
  Added the ability to do a raster_join on proj_raster types. Fixes locationtech#419.
  Add landsat masking section to masking docs page
  Add mask bits  python api and unit test
  Extract bits should throw on non-integral cell types
  Fix for both masking by def and value; expand code comments; update tests
  Python regression.
  Masking improvements and unit tests.
  Regression
  Added (disabled) integration test for profiling spatial index effects. Reorganized non-evaluated documentationm files to `docs`.
  Add failing unit test for mask by value on 0
  Updated python tests against spatial index functions.
  ...

# Conflicts:
#	core/src/main/scala/org/locationtech/rasterframes/expressions/DynamicExtractors.scala
#	core/src/main/scala/org/locationtech/rasterframes/expressions/transformers/XZ2Indexer.scala
#	core/src/main/scala/org/locationtech/rasterframes/extensions/Implicits.scala
#	core/src/test/scala/examples/CreatingRasterFrames.scala
#	core/src/test/scala/org/locationtech/rasterframes/RasterLayerSpec.scala
#	core/src/test/scala/org/locationtech/rasterframes/expressions/XZ2IndexerSpec.scala
#	datasource/src/main/scala/org/locationtech/rasterframes/datasource/raster/RasterSourceRelation.scala
#	datasource/src/test/scala/org/locationtech/rasterframes/datasource/raster/RasterSourceDataSourceSpec.scala
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug When it really isn't a "feature".
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added the ability to do a raster_join on proj_raster types. s22s/rasterframes
2 participants
@metasim @vpipkt