Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coveralls config #4206

Merged
merged 16 commits into from
Jun 28, 2021
Merged

Update coveralls config #4206

merged 16 commits into from
Jun 28, 2021

Conversation

thrau
Copy link
Member

@thrau thrau commented Jun 25, 2021

fixes #4200

@thrau thrau marked this pull request as draft June 27, 2021 10:25
@thrau
Copy link
Member Author

thrau commented Jun 27, 2021

slow build times in docker could have the same reason as this issue: pytest-dev/pytest-cov#159

@thrau
Copy link
Member Author

thrau commented Jun 27, 2021

still one issue left to get it over the line:
the coverage database includes the absolute file paths to code files. the path inside the docker containers are /opt/code/localstack/..., once copied outside of the container, the files are under a different path and therefore the coverage data isn't reported correctly.

symlinking doesn't work, coverage doesn't appear to follow symlinks.

@thrau
Copy link
Member Author

thrau commented Jun 27, 2021

Coverage results are not correct in coveralls now... Maybe relative paths will work: nedbat/coveragepy#597

@thrau
Copy link
Member Author

thrau commented Jun 28, 2021

🎉 coverage results are back online! https://coveralls.io/builds/40929854

@thrau thrau marked this pull request as ready for review June 28, 2021 14:55
@thrau thrau requested a review from whummer June 28, 2021 14:55
@whummer
Copy link
Member

whummer commented Jun 28, 2021

Awesome 🎉 , thanks @thrau !!

@whummer whummer merged commit 18f6351 into master Jun 28, 2021
@whummer whummer deleted the coveralls branch June 28, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix coveralls coverage reporting
2 participants