Release 1.0.0-beta9

[andybroomfield]

• adds feedback form (adds feedback form #92)
• fix: add return types fix: add return types #105
• fix: yaml linting issues fix: yaml linting issues #103
• fix: css linting issues fix: css linting issues #104

[andybroomfield]

Bunch of failed tests, but should that hold up release as this may be updates to PHPstan / PHPcs?

[finnlewis]

Good question, @millnut or @ekes can you tell with a quick glance whether the PHP coding standards and static analysis check failures are a) introduced by changes to phpstan / phpcs and b) should we fix them before release and if so c) are they quick to fix?

[millnut]

@finnlewis phpstan errors are real as they won't be included in the project baseline as forms is not part of the main project.

The coding standards should be fixed. The phpstan error I can add them to the baseline however we don't have any other case where a module that is not included in the main project is added to the baseline, so unsure if we want to start doing this.

[finnlewis]

@andybroomfield is happy to release with errors, but we might want to fix them if we can.

If we can rattle through and address the phstan issues, that would be great!

[finnlewis]

If we can't fix the phpstan issues, let's create a separate issue for that and get this release out!

[millnut]

@finnlewis already fixed the phpstan errors today :) Just with Adnan to take a look #105 due to the PHPUnit failures. But we haven't had a successful PHPUnit test since a couple of months ago

[andybroomfield]

@Adnan-cds Ok for this to be released?

[Adnan-cds]

👍

[Adnan-cds]

Ok for this to be released?

Sure.