Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds documents to linkit profile #254

Draft
wants to merge 1 commit into
base: 2.x
Choose a base branch
from

Conversation

markconroy
Copy link
Member

Closes #253

What does this change?

  • Adds documents as an allowed type in the LinkIt matchers.
  • Sets the URL to be "canonical" (/media/123 - I think). Would we prefer this to be "Direct link to the media file"?

How to test

Try to link to a document in a wysiwyg, you should see "Document: [media - name]" for available documents in your linkit suggestions.

Have we considered potential risks?

I'm not fully sure what happens when a document is changed/gets a new file.


Thanks to Big Blue Door for sponsoring my time to work on this.

@finnlewis
Copy link
Member

Sounds like we need a bit of testing.
Hoping @ekes might be able to explain the complexity.

Also: some councils are using less ckeditor embedded buttons and are using paragraphs more.

@finnlewis
Copy link
Member

What is the expected behaviour of a LinkIt link to a document?

Is it:

a) to the canonical url of the media item (/media/123)
b) to the file that is the target of the media item? (/sites/default/files/my-file.pdf)
c) to a download link (/media/123/download)

@finnlewis
Copy link
Member

I think this is with @willguv to check with content people.

@stephen-cox
Copy link
Member

Discussing this again at Merge Tuesday - need to understand the tech complexities - will create a Slack chat on this.

@finnlewis
Copy link
Member

@willguv have you had a chance to chat about this one with content people yet? Thanks dude!

@willguv
Copy link
Member

willguv commented Nov 26, 2024

Hi @finnlewis not yet sorry - thanks for the nudge

Can we describe in content designer language what this PR describes? Or can we spend a bit of our session next Monday looking at it/ writing something?

@finnlewis finnlewis marked this pull request as draft December 3, 2024 12:23
@finnlewis
Copy link
Member

Discussing this with @willguv , this is part of a bigger review about how we want to guide people on best practice for displaying documents. Converting to draft for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 2025 'Refresh' mission [REFINE AND PRIORITISE]
Development

Successfully merging this pull request may close these issues.

Make it easier to add documents to pages
4 participants