-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds documents to linkit profile #254
base: 2.x
Are you sure you want to change the base?
Conversation
Sounds like we need a bit of testing. Also: some councils are using less ckeditor embedded buttons and are using paragraphs more. |
What is the expected behaviour of a LinkIt link to a document? Is it: a) to the canonical url of the media item (/media/123) |
I think this is with @willguv to check with content people. |
Discussing this again at Merge Tuesday - need to understand the tech complexities - will create a Slack chat on this. |
@willguv have you had a chance to chat about this one with content people yet? Thanks dude! |
Hi @finnlewis not yet sorry - thanks for the nudge Can we describe in content designer language what this PR describes? Or can we spend a bit of our session next Monday looking at it/ writing something? |
Discussing this with @willguv , this is part of a bigger review about how we want to guide people on best practice for displaying documents. Converting to draft for now. |
Closes #253
What does this change?
How to test
Try to link to a document in a wysiwyg, you should see "Document: [media - name]" for available documents in your linkit suggestions.
Have we considered potential risks?
I'm not fully sure what happens when a document is changed/gets a new file.
Thanks to Big Blue Door for sponsoring my time to work on this.