Update readme with instructions on disabling CSS #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #247 This provides the details in the readme, will open a new issue for the config option.
|
Minor so merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #247
This provides the details in the readme, will open a new issue for the config
option.
What does this change?
Provides info in the readme on how to disable the provided css.
How to test
Try to apply the instructions to a custom theme.
How can we measure success?
Themers can provide their own alert banner css without the CSS from the module.
Have we considered potential risks?
People can miss the readme, in future this will also be a config option.
Images
n/a
Accessibility
n/a