fix/1.x 363 emergency publisher perms #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so the alert banners menu option is avalible in the toolbar
This permission isn't nessecary to access these pages.
Use a function to install default permissions on install for emergency publisher based on if node or toolbar is installed. Also move the default anon / authenticated users to the set_default_permissions() function. Also only proceed during first install, not on config sync operations.
…b.com/localgovdrupal/localgov_alert_banner into fix/1.x-363-emergency-publisher-perms
ea4cc1e to
dac38a2
Compare
|
So this was due to changes to emergency publisher installing permissions that are not defined during the test runs. |
finnlewis
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #363
What does this change?
Adds the following permisions to the emergency publisher role
This is to allow users with just the emergency publisher role to access the manage alert banners screen from the toolbar menu.
How to test
Create a user with just the emergency publisher role and check they can navigate to content -> alert banners in the top menu.
How can we measure success?
Users with this role can now access the alert banners screen on default setup.
Have we considered potential risks?
Gives access to access content overview, which they should'nt really need. Risk is small since typically those with this role would have access to that anyway. However since this PR is about those with just this role, it does give rise to asking if a seperate menu item should now be provided.
Images
n/a
Accessibility
n/a