Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.6.3 #278

Merged
merged 2 commits into from
Aug 16, 2023
Merged

1.6.3 #278

merged 2 commits into from
Aug 16, 2023

Conversation

andybroomfield
Copy link
Contributor

andybroomfield and others added 2 commits July 31, 2023 19:32
@andybroomfield
Hide moderation controls when present on confirmation form page
0ee8369 
Fix #236

Adds a preprocess implementation to the alert banner to hide the moderation
controls if they have been displayed when on the confirmation page
(status form).

Note: This only hides on the confirmation form page eg.
/admin/content/alert-banner/18/status

If the form is included in another way it will still be present.

This way, moderation controls can be placed on an alert banner manage display
if a site builder considers that desirable, without interfering with the
confirmation form to put an alert banner live.
@andybroomfield
Merge pull request #273 from localgovdrupal/fix/1.x-236-hide-confirma…
f0ef42d 
…tion-form

Hide moderation controls when present on confirmation form page
@andybroomfield
Copy link
Contributor Author

Able to self approve as the PR has been approved.
We know the test failure is something to do with Chromedriver update.

@andybroomfield andybroomfield merged commit 3100f93 into release-1.x Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andybroomfield