1.5.7 Release #254
Merged
1.5.7 Release #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #251 During config sync operations, if creating a new alert banner type the visibility field will try to be created, even though that is part of config. This checks if the isSyncing flag is set and skips over the postSave actions as we assume they are part of the config being imported.
…ent banners During import, and in times where the type_of_alert field has been deleted, the getCurrentBanners method will try to perform an entity query, but it needs to check the field is present before adding a sort.
Skip alert type postsave during config sync and skip type of alert in block if not present
|
As this is a release PR it can be merged ok. |
1 similar comment
|
As this is a release PR it can be merged ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the config import fix