Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.5.2 release #226

Merged
merged 5 commits into from
Nov 7, 2022
Merged

1.5.2 release #226

merged 5 commits into from
Nov 7, 2022

Conversation

andybroomfield
Copy link
Contributor

No description provided.

Oliver Davies and others added 3 commits October 24, 2022 08:32
Ensure that the title for "Death of a notable person" alerts is set to a
colour and doesn't default to black and is then hidden on top of the
background colour, which is also black.
Target .localgov-alert-banner .localgov-alert-banner__title
and use inherit as the colour value.
Set the title colour for notable person messages
@andybroomfield
Copy link
Contributor Author

The test fail is becuase javascript tests are broken, however this release is just a css change.

@andybroomfield
Copy link
Contributor Author

Checked visually.

Screenshot 2022-11-07 at 2 40 53 pm

And Bartick
Screenshot 2022-11-07 at 2 41 36 pm

andybroomfield and others added 2 commits November 7, 2022 14:51
Apply the reset to .text-content class also.
…r-body-text

Reset the alert banner body text colour when using Olivero theme
@andybroomfield
Copy link
Contributor Author

Added Olivero compatability.

Copy link
Member

@finnlewis finnlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@andybroomfield andybroomfield merged commit d00d82b into release-1.x Nov 7, 2022
@finnlewis
Copy link
Member

We know the tests are failing, but that is unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants