Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.4.2 (or maybe 1.5?) #220

Merged
merged 4 commits into from
Jul 11, 2022
Merged

1.4.2 (or maybe 1.5?) #220

merged 4 commits into from
Jul 11, 2022

Conversation

andybroomfield
Copy link
Contributor

Minor update that adds official support for Drupal 10 to the alert banner.
(note: the full screen alert banner will need to wait until localgov_core formally supports Drupal 10).

andybroomfield and others added 4 commits June 7, 2022 16:29
Since field group isn't actully used by this module, remove the dependancy
Fix #207

Now that Condition field supports Drupal 10, and we don't need the field group
dependency, this module can officially support Drupal 10.
… d10

Without needing field group, the full page alert submodule can support
Drupal 10 once localgov_core has a Drupal 10 release.
@andybroomfield andybroomfield requested review from Adnan-cds and stephen-cox and removed request for Adnan-cds July 11, 2022 13:10
Copy link
Contributor

@Adnan-cds Adnan-cds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay :)

@finnlewis
Copy link
Member

Just chatting in Merge Monday - we reckon a 1.5 release is best, as it does remove field_group and adds support for Drupal 10.

@andybroomfield andybroomfield merged commit badb441 into release-1.x Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants