-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JS Cookie library deprecated in Drupal 10.1, removed in Drupal 11 without replacement #271
Comments
... or refactor the code to remove the dependency, could be done at the same time as removing the jQuery dependency (#201) |
I would probably recommend using vanilla javascript and then switching out cookies in favour of localstorage. |
That js-cookie module just does one thing: get the js-cookie JS from https://github.com/js-cookie/js-cookie so that it can be used in a Drupal site. I think the simplest thing is to update our === |
What's the thinking behind using localStorage instead of a cookie? |
Fix #271 Small refactor to remove the js-cookie dependancy by using native javascript cookie read and write methods.
We've removed it from the main module in 1.8x. |
So does this mean we need to declare a dependancy on it directly and ask users to download it to the libraries folder? Or just include a copy.
The text was updated successfully, but these errors were encountered: