Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

202 prepare water level interpretation #203

Merged
merged 9 commits into from
Feb 14, 2025

Conversation

hcwinsemius
Copy link
Collaborator

  • This version adds provisions for water level detection.
  • Small additions in the command-line interface utils. rotation and translation vectors are returned in the interactive optimization function.

@hcwinsemius hcwinsemius self-assigned this Feb 14, 2025
@hcwinsemius hcwinsemius linked an issue Feb 14, 2025 that may be closed by this pull request
4 tasks
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 72.79152% with 77 lines in your changes missing coverage. Please review.

Project coverage is 83.25%. Comparing base (03bdef3) to head (afa5b7c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pyorc/api/cross_section.py 80.58% 33 Missing ⚠️
pyorc/cli/cli_elements.py 65.11% 15 Missing ⚠️
pyorc/cli/cli_utils.py 62.85% 13 Missing ⚠️
pyorc/plot_helpers.py 54.54% 10 Missing ⚠️
pyorc/cv.py 14.28% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
- Coverage   83.85%   83.25%   -0.61%     
==========================================
  Files          24       26       +2     
  Lines        3271     3469     +198     
==========================================
+ Hits         2743     2888     +145     
- Misses        528      581      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hcwinsemius hcwinsemius merged commit d0d1801 into main Feb 14, 2025
2 of 4 checks passed
@hcwinsemius hcwinsemius deleted the 202-prepare-water-level-interpretation branch February 14, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare water level interpretation
1 participant