API call for making a new offer #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41ca3f2 to
0102def
Compare
7b5b5ef to
4f98fa3
Compare
427689a to
c04cbd8
Compare
carlaKC
reviewed
Nov 17, 2023
| @@ -139,6 +143,27 @@ impl Node { | |||
| } | |||
| } | |||
|
|
|||
| // build an offer to receive payments at this node. path_pubkeys lists the nodes the path will contain, | |||
| // starting with the introduction node and ending in the destination node (the current node). | |||
| pub async fn create_offer( | |||
There was a problem hiding this comment.
Out of interest - do you think there's any chance of this being added to ldk_sample upstream?
8d3b4cb to
848e562
Compare
As described in orbitalturtle/rust-lightning#2 we need to temporarily bump rust-lightning dependencies to avoid dependency conflicts in lndk.
Add options to configure the logging level and ldk node number (to identify each ldk node in lndk's integration tests). Also add a couple helpful logs.
We don't need this for LNDK's integration tests.
|
Merging this since my next PR depends on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add a new API call to allow building BOLT 12 offers! We need this for our integration tests over at lndk.