Fix the url in the "build" badge in the readme #197
Conversation
|
The URL works for me, but I think the target should be to show the success or failure of the test, not the test script itself. I would recommend a target of https://github.com/lmfit/uncertainties/actions/workflows/python-package.yml Also: if you are editing "README.rst", perhaps the call for maintainers should be removed too ;) |
|
Ok, I pointed the url to the actions page instead of the action source code. I also removed the call for maintainers. Should this go in another PR though? On this specific one though, I'd like to give @lebigot a chance to veto this change though since he put the message there in the first place and I feel like I'd be happy to know he's satisfied before removing the message. |
| :target: https://github.com/lmfit/uncertainties/blob/main/.github/workflows/python-package.yml | ||
|
|
||
| **Call for maintainers**: if you want this project to keep living and are ready to maintain it (pull requests management, issue resolution…), please contact me! I am ready to share my knowledge of the code logic by participating in discussions (notably around pull requests and issues). | ||
| :target: https://github.com/lmfit/uncertainties/actions/workflows/python-package.yml |
|
@jagerber48 Thanks -- this looks good to me. If there are no objections, I'd be happy to merge within a couple of days. |
Good with me! Based on my past interactions with all of you, I consider that the right people are now at the helm, and I trust that you'll welcome other people based on the contributions that they want to make! |
|
@jagerber48 let's start by merging this one! |
See #194 (comment)
Test the correct url here on my fork.