Temporarily revert support for custom op extensions. #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MacOS builders are having linking trouble with the extension library. Until it's fixed, all support for op extensions is disabled. It should be easy to restore once the issue is resolved.
|
@silvasean @powderluv This is passing on my dev machine, just waiting for the CI tests. If those pass, I'll merge and wait for the MacOS builders to trigger. Assuming those pass, we should be good. I've confirmed that the |
|
Thanks! |
qedawkins
pushed a commit
to nod-ai/torch-mlir
that referenced
this pull request
Oct 3, 2022
* initial pass at compress Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * update Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * progress Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * progress Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * update Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * update Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * update Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * factored affine builder out of krnltoaffine Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * migrated AffineBuilder to MLIRDialectBuilder to be more usable in other phases than just KrnlToAffine Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * working but wrong algo for axis>0 Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * works with removed condition on cond size when known at compile time Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * added lit tests Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * format Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * fix compiler errors and warnings Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * missing lib include resulting in Release mode failure to build onnx-mlir Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * format Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * update for latest LLVM Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * respond to review requests Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * added const and final to all builders class and methods Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MacOS builders are having linking trouble with the extension library.
Until it's fixed, all support for op extensions is disabled. It should be
easy to restore once the issue is resolved.