Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a CMake option to enable TOSA. Default to ON. #4021

Merged
merged 3 commits into from
Feb 12, 2025
Merged

Add a CMake option to enable TOSA. Default to ON. #4021

merged 3 commits into from
Feb 12, 2025

Conversation

bjacob
Copy link
Contributor

@bjacob bjacob commented Feb 12, 2025 •
edited
Loading

Fixes #4019.

@bjacob
cmake-option-tosa
9c321d2 
Signed-off-by: Benoit Jacob <jacob.benoit.1@gmail.com>
@bjacob
newline
dfe388c 
Signed-off-by: Benoit Jacob <jacob.benoit.1@gmail.com>
@bjacob bjacob marked this pull request as ready for review February 12, 2025 18:00
@bjacob bjacob requested a review from ScottTodd February 12, 2025 18:00
@bjacob
Copy link
Contributor Author

bjacob commented Feb 12, 2025

FYI @justin-ngo-arm (somehow, I can't add you as reviewer).

@justin-ngo-arm
Copy link
Contributor

@bjacob This looks reasonable to me. You can add @sjarus as a reviewer as he has merge access to this repo.

sjarus
sjarus approved these changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@sjarus sjarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me with default ON.

ScottTodd
ScottTodd approved these changes Feb 12, 2025
View reviewed changes
@bjacob
review-comment
05c549f 
Signed-off-by: Benoit Jacob <jacob.benoit.1@gmail.com>
@bjacob bjacob enabled auto-merge (squash) February 12, 2025 18:44
@bjacob bjacob merged commit c9694c6 into llvm:main Feb 12, 2025
3 checks passed
@sjain-stanford sjain-stanford mentioned this pull request Feb 12, 2025
Merged
sjain-stanford added a commit that referenced this pull request Feb 13, 2025
@sjain-stanford
Enable TOSA conversions in bazel build rules (#4023)
7b8d0bd 
Follows #4021.

Also pushes a small pre-commit fix.

Bazel CI triggered here:
https://github.com/sjain-stanford/torch-mlir/actions/runs/13297425038/job/37132415527
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScottTodd ScottTodd ScottTodd approved these changes

@sjarus sjarus sjarus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make building TOSA support optional
4 participants
@bjacob @justin-ngo-arm @ScottTodd @sjarus