Support default padding case for tosa::AvgPool in the presence of count_include_pad #3868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce of count_include_pad
|
Hi @sjarus, @dbabokin, @sahas3, @justin-ngo-arm, @rafaelubalmw, could you please take a look at this change? |
|
This looks reasonable to me. @sjarus, do you have any further comments? |
sjarus
approved these changes
Nov 12, 2024
|
Thanks a lot, @Hanumanth04! I'll go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially, as part of my earlier change , I didn't consider the
paddingvalue while erroring out for unsupportedcount_include_padduringtorch-to-tosalowering for AvgPool2d. The fix captured in this change addresses this. Please see issue for more details on this.