[TOSA] Fix rsub; add clamp.Tensor, avg_pool1d, max_pool1d, prims.collapse #3855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…apse - Fix aten.rsub.Scalar legalization with appropriate type casting - Add legalization for aten.clamp.Tensor - Resolve some unexpected test failures from PyTorch update by adding legalization for the following ops: + aten.avg_pool1d + aten.max_pool1d + torch.prims.collapse - Update xfail_sets with new e2e results - Add new LIT tests to basic.mlir Signed-off-by: Justin Ngo <justin.ngo@arm.com> Change-Id: I9762c7d36ca0b0f75ca68d0c71d7f5d5309a96ad
|
@justin-ngo-arm, @sjarus -- As FYI please expect a bit delay in reviewing as I am traveling for work this week and the next. I'll review as soon as I get some time. Thanks! |
Change torch.aten.uniform LIT test to check for tosa.const instead of the random values generated to ensure the test works on different platforms. Signed-off-by: Justin Ngo <justin.ngo@arm.com>
sjarus
approved these changes
Nov 7, 2024
|
Hi @dbabokin , I just added the fix to this PR which just got merged. Please let me know if this resolve your problem. |
This was referenced Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I9762c7d36ca0b0f75ca68d0c71d7f5d5309a96ad