-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MLIR][TORCH] Add torch-onnx-to-torch-backend pipeline #3801
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like we were discussing in the sync, I think since scalarize shapes is really onnx specific right now, we should only perform this pass in the onnx-to-torch pipeline.
37e9a8d
to
4515220
Compare
4515220
to
179545a
Compare
This commit adds the torch-onnx-to-torch-backend pipeline which converts the Torch Onnx IR to Torch Backend IR. This commit also moves the `ScalarizeShapes` pass from the `torch-backend-to-linalg-on-tensors-backend-pipeline` to the `torch-onnx-to-torch-backend` pipeline since the primary goal of this pass is to scalarize the shapes in the IR coming from the Onnx models. Signed-Off By: Vivek Khandelwal <vivekkhandelwal1424@gmail.com>
179545a
to
967a8b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, a few changes and I think we should be good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last quick change (sorry for the back and forth), then I think this is good to go. Glad to see the CI green on this change.
d46490e
to
ccc65fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good starting point. Let's get this in and iterate on the pipeline as the need arises.
This commit adds the torch-onnx-to-torch-backend pipeline which
converts the Torch Onnx IR to Torch Backend IR.
This commit also moves the
ScalarizeShapes
pass from thetorch-backend-to-linalg-on-tensors-backend-pipeline
to thetorch-onnx-to-torch-backend
pipeline since the primary goal ofthis pass is to scalarize the shapes in the IR coming from the
Onnx models.