[onnx] Update DefaultDomainGtoP.cpp gridsampler #3228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gridsampler In onnx the interpolation mode is called 'linear' whereas in pytorch it is called 'bilinear'. This led to the problem that everything other than 'bilinear' was rejected. It needed to be changed to linear.
jinchen62
approved these changes
Apr 25, 2024
|
why is no runner picking up this job ? |
The interpolation terminology changed between linear and bilinear. We are supporting both which do the same exact thing. The newer standard is calling it linear whereas earlier standards are referring to bilinear. So in the moment we decided to support both naming conventions.
jinchen62
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gridsampler
In onnx the interpolation mode is called 'linear' whereas in pytorch it is called 'bilinear'. This led to the problem that everything other than 'bilinear' was rejected. It needed to be changed to linear.