build: manually update PyTorch version #3094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43cb837 to
db82ae8
Compare
|
@stellaraccident who's the right person to ask for looking at the LTC failures? |
|
You can ask on discord, but the agreement is to disable and keep moving. |
Set PyTorch and TorchVision version to nightly release 2024-04-01. This commit also disables the LTC build. Signed-Off By: Vivek Khandelwal <vivekkhandelwal1424@gmail.com>
db82ae8 to
8d78cbc
Compare
stellaraccident
approved these changes
Apr 3, 2024
qingyunqu
reviewed
Apr 6, 2024
| @@ -5868,6 +5868,24 @@ StringRef mlir::torch::Torch::getAbstractInterpLibrary() { | |||
| " %3 = torch.prim.TupleConstruct %1, %0, %0 : !torch.list<int>, !torch.list<int>, !torch.list<int> -> !torch.tuple<list<int>, list<int>, list<int>>\n" | |||
| " return %3 : !torch.tuple<list<int>, list<int>, list<int>>\n" | |||
| " }\n" | |||
| " func.func @__torch__.torch.jit._shape_functions._batch_norm_with_update(%arg0: !torch.list<int>, %arg1: !torch.optional<list<int>>, %arg2: !torch.optional<list<int>>, %arg3: !torch.optional<list<int>>, %arg4: !torch.optional<list<int>>) -> !torch.tuple<list<int>, list<int>, list<int>, list<int>> {\n" | |||
There was a problem hiding this comment.
I think that you forget to adding shape function of _batch_norm_with_update in abstract_interp_lib_gen.py? @vivekkhandelwal1
There was a problem hiding this comment.
I think that you forget to adding shape function of
_batch_norm_with_updateinabstract_interp_lib_gen.py? @vivekkhandelwal1
No, this change comes from the upstream addition of this shape function.
There was a problem hiding this comment.
But why the ci passed?
The same reason as above + we disabled the LTC build.
josel-amd
added a commit
to Xilinx/torch-mlir
that referenced
this pull request
Jul 29, 2024
These changes allow to bump torch-nightly to a version that still exists.
josel-amd
added a commit
to Xilinx/torch-mlir
that referenced
this pull request
Jul 29, 2024
These changes allow to bump torch-nightly to a version that still exists.
josel-amd
added a commit
to Xilinx/torch-mlir
that referenced
this pull request
Jul 29, 2024
These changes allow to bump torch-nightly to a version that still exists.
josel-amd
pushed a commit
to Xilinx/torch-mlir
that referenced
this pull request
Jul 29, 2024
Set PyTorch and TorchVision version to nightly release 2024-04-01. Signed-Off By: Vivek Khandelwal <vivekkhandelwal1424@gmail.com>
josel-amd
pushed a commit
to Xilinx/torch-mlir
that referenced
this pull request
Jul 29, 2024
Set PyTorch and TorchVision version to nightly release 2024-04-01. Signed-Off By: Vivek Khandelwal <vivekkhandelwal1424@gmail.com>
josel-amd
pushed a commit
to Xilinx/torch-mlir
that referenced
this pull request
Jul 29, 2024
Set PyTorch and TorchVision version to nightly release 2024-04-01. Signed-Off By: Vivek Khandelwal <vivekkhandelwal1424@gmail.com>
josel-amd
pushed a commit
to Xilinx/torch-mlir
that referenced
this pull request
Jul 29, 2024
Set PyTorch and TorchVision version to nightly release 2024-04-01. Signed-Off By: Vivek Khandelwal <vivekkhandelwal1424@gmail.com>
josel-amd
pushed a commit
to Xilinx/torch-mlir
that referenced
this pull request
Jul 29, 2024
Set PyTorch and TorchVision version to nightly release 2024-04-01. Signed-Off By: Vivek Khandelwal <vivekkhandelwal1424@gmail.com>
josel-amd
pushed a commit
to Xilinx/torch-mlir
that referenced
this pull request
Jul 29, 2024
Set PyTorch and TorchVision version to nightly release 2024-04-01. Signed-Off By: Vivek Khandelwal <vivekkhandelwal1424@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set PyTorch and TorchVision version to nightly release 2024-04-01.
Signed-Off By: Vivek Khandelwal vivekkhandelwal1424@gmail.com