Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dynamo] Verify the default value is passed by kwargs #2998

Merged
merged 2 commits into from
Apr 27, 2024
Merged

[dynamo] Verify the default value is passed by kwargs #2998

merged 2 commits into from
Apr 27, 2024

Conversation

penguin-wwy
Copy link
Collaborator

Four xfailed cases due to this reason. They can pass after fixing it.

ElementwiseDivRoundingModeFloorModule_basic
ElementwiseDivRoundingModeTruncModule_basic
RandnGeneratorF64Module_basic
RandnGeneratorModule_basic

@penguin-wwy penguin-wwy force-pushed the fix_dynamo branch 2 times, most recently from e1c672e to 0d50ec2 Compare March 11, 2024 07:02
@penguin-wwy penguin-wwy mentioned this pull request Mar 18, 2024
Open
@penguin-wwy
Copy link
Collaborator Author

Although torchdynamo has been deprecated, this PR should have no side effects.

@penguin-wwy penguin-wwy merged commit 4fbe77a into llvm:main Apr 27, 2024
3 checks passed
stellaraccident
stellaraccident reviewed Apr 27, 2024
View reviewed changes
Copy link
Collaborator

@stellaraccident stellaraccident left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

archana-ramalingam pushed a commit to archana-ramalingam/torch-mlir that referenced this pull request May 8, 2024
@penguin-wwy @archana-ramalingam
[dynamo] Verify the default value is passed by kwargs (llvm#2998)
438e419
archana-ramalingam pushed a commit to archana-ramalingam/torch-mlir that referenced this pull request May 8, 2024
@penguin-wwy @archana-ramalingam
[dynamo] Verify the default value is passed by kwargs (llvm#2998)
3b7fef7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stellaraccident stellaraccident stellaraccident left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@penguin-wwy @stellaraccident