Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a typing dependency that is not in older PyTorch backwards compatible. #2948

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Make a typing dependency that is not in older PyTorch backwards compatible. #2948

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be4c231
Make a typing dependency that is not in older PyTorch backwards compa…
stellaraccident Feb 23, 2024
a6450c8
Run black
stellaraccident Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions python/torch_mlir/extras/fx_importer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,18 @@
import re
from dataclasses import dataclass
from types import BuiltinMethodType, BuiltinFunctionType
from typing import Any, Callable, Dict, List, Optional, Sequence, Set, Tuple, Union
from typing import (
Any,
Callable,
Dict,
List,
Optional,
Sequence,
Set,
Tuple,
TYPE_CHECKING,
Union,
)
import weakref

import numpy as np
Expand Down Expand Up @@ -45,6 +56,16 @@
Node,
)

try:
from torch.export.graph_signature import InputSpec as TypingInputSpec
except ModuleNotFoundError:
# PyTorch prior to 2.3 is missing certain things we use in typing
# signatures. Just make them be Any.
if not TYPE_CHECKING:
TypingInputSpec = Any
else:
raise

try:
import ml_dtypes
except ModuleNotFoundError:
Expand Down Expand Up @@ -282,7 +303,7 @@ class InputInfo:
"""Provides additional metadata when resolving inputs."""

program: torch.export.ExportedProgram
input_spec: torch.export.graph_signature.InputSpec
input_spec: TypingInputSpec
node: Node
ir_type: IrType
mutable_producer_node_name: Optional[str] = None
Expand Down
Loading