Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[torch] Folders for torch.aten.*.tensor operators [add, sub, mul] #2878

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

rsuderman
Copy link
Contributor

Simple folder for limited size aten tensor operations. This is primarily
useful for shape computation folding as they unfortunately can use
aten operators. Add, sub, mul are common examples of these folders.

Simple folder for limited size aten tensor operations. This is primarily
useful for shape computation folding as they unfortunately can use
`aten` operators. Add, sub, mul are common examples of these folders.
Copy link
Collaborator

@daveliddell daveliddell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned offline, as part of a bigger effort, I wouldn't mind seeing the duplicated handling of dtypes brought under some kind of unified umbrella, not specifically for this PR but in general.

Nice set of test cases for so many different possibilities!

@rsuderman rsuderman merged commit e80054a into llvm:main Feb 19, 2024
3 checks passed
@rsuderman rsuderman deleted the tensor_folders branch February 28, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants