-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove build automation that is no longer used. #2839
base: main
Are you sure you want to change the base?
Conversation
Most of this can't actually work given the token/security issues, so even if we re-introduce it, we are better off fetching from history vs carrying things that will lead folks astray.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@sjain-stanford since I authored this PR, you started using some of the bits in the torch-mlir-release repo. Could you let me know if I'm deleting anything in this patch that you need and I'll revert those parts. |
Thanks for checking @stellaraccident . We'll need to keep the |
Here's the updated list:
Reverting the first one and landing SGTM. If the nightly release tomorrow breaks, we can send a fix PR as a follow-on. |
@@ -225,106 +225,6 @@ is built as part of the LLVM project along with MLIR. | |||
We mount a ccache and pip cache inside the docker container to speed up iterative builds. Iterative | |||
builds should be as fast as running without docker. | |||
|
|||
### In-Tree builds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small request: Could you paste the stuff being removed from docs/development.md
into build_linux_packages.sh
(as comments) for future reference? Some of this is useful info and carrying it forward makes sense in the script (not in the readme).
Most of this can't actually work given the token/security issues, so even if we re-introduce it, we are better off fetching from history vs carrying things that will lead folks astray.