[onnx] Fix pool lowering for non-symmetric padding
#2837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`torch` requires that padding be symmetric for pooling operations. To support non-symmetric pad we need to separately materialize out the padding operation.
newling
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Nice code. The lit test is rather long, but they all are in these onnx->torch tests. The quick numerical tests would be good for this, if/when possible. Especially good for testing complex combinations of padding, dilation and striding (does pooling start top-left of padded image?) in the future
@renxida might want to take a look.
Co-authored-by: James Newling <james.newling@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
torchrequires that padding be symmetric for pooling operations. Tosupport non-symmetric pad we need to separately materialize out the
padding operation.