Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[torch] Supporting torch.aten.mul.float lowering to arith #2833

Merged
merged 2 commits into from
Feb 6, 2024
Merged

[torch] Supporting torch.aten.mul.float lowering to arith #2833

merged 2 commits into from
Feb 6, 2024

Conversation

rsuderman
Copy link
Contributor

Simple missing scalar operation for multiply floats was missing.

@rsuderman
[torch] Supporting torch.aten.mul.float lowering to arith
53b71e0 
Simple missing scalar operation for multiply floats was missing.
@rsuderman rsuderman requested a review from renxida January 31, 2024 01:19
@rsuderman rsuderman requested a review from daveliddell February 5, 2024 23:34
daveliddell
daveliddell approved these changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@daveliddell daveliddell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I get it :-)

@rsuderman rsuderman merged commit 041a54a into llvm:main Feb 6, 2024
3 checks passed
@rsuderman rsuderman deleted the scalar_mul_float branch February 28, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daveliddell daveliddell daveliddell approved these changes

@renxida renxida Awaiting requested review from renxida

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rsuderman @daveliddell