[onnx] Import onnx constants as onnx.Constant instead of literals
#2831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To handle the conversion from raw bytes to `DenseElementsAttr` we need to handle the endianness conversion during `torch-onnx-to-torch`. Therefore when importing `onnx.Constant` it is better to represent using the `onnx` constant operation so that only one location requires the endianness correction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To handle the conversion from raw bytes to
DenseElementsAttrwe needto handle the endianness conversion during
torch-onnx-to-torch.Therefore when importing
onnx.Constantit is better to represent usingthe
onnxconstant operation so that only one location requires theendianness correction.