Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[torch-mlir] provide FX traced graph importer for sparse tensors #2817

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

aartbik
Copy link
Contributor

@aartbik aartbik commented Jan 27, 2024

Note that we are waiting for actual FX traced graph support for sparse tensors. For details see

pytorch/pytorch#117188

Until then, however, we provide this clever importer that builds the FX traced graph for for the dense case and then puts a sparse annotation back on the parameters.

With import test.

Note that we are waiting for actual FX traced graph support
for sparse tensors. For details see

pytorch/pytorch#117188

Until then, however, we provide this clever importer that
builds the FX traced graph for for the dense case and then
puts a sparse annotation back on the parameters.

With import test.
Copy link
Collaborator

@stellaraccident stellaraccident left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't quite ready to accept contributions to this part yet. Let me synchronize the downstream fork tomorrow and make sure we don't get into a merge conflict.

@aartbik
Copy link
Contributor Author

aartbik commented Jan 29, 2024

I wasn't quite ready to accept contributions to this part yet. Let me synchronize the downstream fork tomorrow and make sure we don't get into a merge conflict.

I suspect conflicts will be very light, since I am only touching a few tensor type building parts. But let me know when you are ready.

Copy link
Collaborator

@stellaraccident stellaraccident left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine but I'm just trying to juggle less. I'm juggling a downstream pr and almost have the spice flowing to not need the fork. Give me a few hours

@aartbik
Copy link
Contributor Author

aartbik commented Jan 29, 2024

Should be fine but I'm just trying to juggle less. I'm juggling a downstream pr and almost have the spice flowing to not need the fork. Give me a few hours

Of course. Take your time! Just reply here when you are comfortable moving forward.

@stellaraccident stellaraccident merged commit 105aad6 into llvm:main Jan 31, 2024
3 checks passed
@stellaraccident
Copy link
Collaborator

I've gone ahead and taken steps to unfork the code from the downstream (iree-org/iree#16276). Will take a release cycle to percolate but in the meantime, we're fine with this minor difference.

@aartbik
Copy link
Contributor Author

aartbik commented Jan 31, 2024

Thanks for your flexibility moving this forward quickly!

@aartbik aartbik deleted the bik branch February 1, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants