Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ONNX][MLIR] support constantOfShape op #2747

Merged
merged 1 commit into from
Jan 26, 2024
Merged

[ONNX][MLIR] support constantOfShape op #2747

merged 1 commit into from
Jan 26, 2024

Conversation

PhaneeshB
Copy link
Collaborator

No description provided.

@PhaneeshB PhaneeshB mentioned this pull request Jan 12, 2024
Closed
@PhaneeshB PhaneeshB marked this pull request as draft January 12, 2024 19:30
@PhaneeshB PhaneeshB force-pushed the onnx_op_const_of_shape branch 2 times, most recently from dbd6f37 to e78aa79 Compare January 19, 2024 19:17
@PhaneeshB PhaneeshB marked this pull request as ready for review January 19, 2024 19:18
@PhaneeshB PhaneeshB changed the title [WIP] support constantOfShape op support constantOfShape op Jan 19, 2024
@PhaneeshB PhaneeshB changed the title support constantOfShape op [ONNX][MLIR] support constantOfShape op Jan 19, 2024
@PhaneeshB PhaneeshB force-pushed the onnx_op_const_of_shape branch 2 times, most recently from d5ab8a4 to 0b64e51 Compare January 25, 2024 21:03
@PhaneeshB PhaneeshB requested a review from rsuderman January 25, 2024 21:16
@PhaneeshB PhaneeshB force-pushed the onnx_op_const_of_shape branch from 0b64e51 to 935c589 Compare January 25, 2024 21:23
rsuderman
rsuderman requested changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@rsuderman rsuderman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor changes and it should be good.

lib/Conversion/TorchOnnxToTorch/DefaultDomainAtoF.cpp Outdated Show resolved Hide resolved
lib/Conversion/TorchOnnxToTorch/DefaultDomainAtoF.cpp Outdated Show resolved Hide resolved
lib/Conversion/TorchOnnxToTorch/DefaultDomainAtoF.cpp Show resolved Hide resolved
@PhaneeshB PhaneeshB force-pushed the onnx_op_const_of_shape branch 2 times, most recently from ea86158 to f80836d Compare January 25, 2024 22:35
@PhaneeshB PhaneeshB force-pushed the onnx_op_const_of_shape branch from f80836d to 308b34f Compare January 26, 2024 16:26
@rsuderman rsuderman merged commit 4964977 into llvm:main Jan 26, 2024
5 checks passed
zjgarvey pushed a commit to zjgarvey/torch-mlir that referenced this pull request Jan 29, 2024
@PhaneeshB @zjgarvey
[ONNX][MLIR] support constantOfShape op (llvm#2747)
98e0156
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsuderman rsuderman rsuderman approved these changes

@vivekkhandelwal1 vivekkhandelwal1 Awaiting requested review from vivekkhandelwal1

@stellaraccident stellaraccident Awaiting requested review from stellaraccident

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhaneeshB @rsuderman