Recommend update_torch_ods.sh for re-generating GeneratedTorchOps.td #2609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stellaraccident
approved these changes
Dec 5, 2023
|
This PR doesn't pass the CI. It will cause other PR failed. You should re-generate |
|
Sorry - didn't catch that. Was used to bypassing the CI for doc/comment fixes and forgot we guarded this gen file like this. I will not be at my keyboard for a few hours. If you are available and would like to revert, please feel free. |
Sorry. Can you trigger the CI on #2612 which contains the regenerated file? |
stellaraccident
pushed a commit
that referenced
this pull request
Dec 5, 2023
…py (#2612) Try to fix the error reported by @qingyunqu in #2609.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2608