Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump llvm-project to f66cd9e9556a53142a26a5c21a72e21f1579217c. #2466

Merged
merged 3 commits into from
Sep 19, 2023

Conversation

stellaraccident
Copy link
Collaborator

Picks up DenseResourceElementsAttr python support and fixes minf/maxf C++ rename.

Picks up DenseResourceElementsAttr python support and fixes minf/maxf C++ rename.
@@ -3,4 +3,4 @@
url = https://github.com/llvm/llvm-project.git
[submodule "externals/stablehlo"]
path = externals/stablehlo
url = https://github.com/openxla/stablehlo.git
url = https://github.com/shark-infra/stablehlo.git
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reasoning for this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the same confusion about this.

Copy link
Collaborator Author

@stellaraccident stellaraccident Sep 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, I'm confused and did something wrong. Let me revert this.

Reconstructing what I think was going on here: my local stablehlo git repo was reporting a commit not found and that was because my repository had a remote of a throwaway fork of stablehlo that I had used locally when doing the switch from mhlo. I saw that it was the old fork and updated, thinking that I had accidentally committed the use of the throwaway fork. I switched it to the fork we use for patching on another project, thinking I needed to land some patches on the branch, but it wasn't intended to land this way.

In any case, unintentional sequence of events matching work I was doing on a peer project. I apologize -- the change was not intentional (and that repo it is pointing to is a pure mirror of stablehlo).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants