[Tcp] Add lowering from Torch to Tcp for tanh, add, and broadcast ops + Enable e2e tests for Tcp #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey folks, I don't really have the bandwidth to participate in detailed code design or review, so I will let you folks iterate on the branch. Let me know if you need any help with Torch-MLIR integration/etc. |
ramiro050
approved these changes
Dec 9, 2022
Comment on lines
+21
to
+24
| """Base class for TestConfig's that are implemented with linalg-on-tensors. | ||
|
|
||
| This class handles all the common lowering that torch-mlir does before | ||
| reaching the linalg-on-tensors abstraction level. |
There was a problem hiding this comment.
i think linalg-on-tensors should be tcp
There was a problem hiding this comment.
I'm not sure what you are referring to here. This is very similar to MhloBackendTestConfig and TosaBackendTestConfig IIUC.
5bc5545 to
925e534
Compare
Thanks a lot for the review. That is very helpful. |
navahgar
added a commit
that referenced
this pull request
Dec 12, 2022
… + Enable e2e tests for Tcp (#1695) * [Tcp] Update parallel iterator types to use the new enum in TcpToLinalg * [Tcp] Add torch-to-tcp pass * [Tcp] Enable Tcp to Linalg conversion pass when TORCH_MLIR_ENABLE_TCP is set * [Tcp] Add torch backend to tcp backend conversion pipeline * [Tcp] Add e2e test for TCP * [Tcp] Update docker script to enable TCP and its e2e tests
navahgar
added a commit
that referenced
this pull request
Jan 5, 2023
… + Enable e2e tests for Tcp (#1695) * [Tcp] Update parallel iterator types to use the new enum in TcpToLinalg * [Tcp] Add torch-to-tcp pass * [Tcp] Enable Tcp to Linalg conversion pass when TORCH_MLIR_ENABLE_TCP is set * [Tcp] Add torch backend to tcp backend conversion pipeline * [Tcp] Add e2e test for TCP * [Tcp] Update docker script to enable TCP and its e2e tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up to #1595. It adds the following:
Each of the above are added as separate commits for easy reviewing.