Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace linear transformation with low and high in test inputs #1485

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Replace linear transformation with low and high in test inputs #1485

merged 1 commit into from
Oct 14, 2022

Conversation

ramiro050
Copy link
Collaborator

This commit replaces test inputs that were being linearly transformed by multiplying and adding/subtracting to the input tensor with inputs that use the low and high keyword arguments instead.

vivekkhandelwal1
vivekkhandelwal1 approved these changes Oct 12, 2022
View reviewed changes
Copy link
Collaborator

@vivekkhandelwal1 vivekkhandelwal1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But the CI is failing, you need to fix the test.

@ramiro050
Copy link
Collaborator Author

LGTM! But the CI is failing, you need to fix the test.

Yeah, i'm currently investigating it. Seems like a lack of precision issue

@ramiro050
Replace linear transformation with low and high in test inputs
9b92de4 
This commit replaces test inputs that were being linearly transformed
by multiplying and adding/subtracting to the input tensor with inputs
that use the `low` and `high` keyword arguments instead.
@ramiro050
Copy link
Collaborator Author

I've made the range for the gelu test to be from -0.5 to 0.5 to make it pass. I've opened an issue #1497 to track the precision error, since that problem is outside the scope of this PR.

@ramiro050 ramiro050 merged commit 86095dd into llvm:main Oct 14, 2022
@ramiro050 ramiro050 deleted the fix-tests branch October 14, 2022 18:52
dellis23 pushed a commit that referenced this pull request Oct 25, 2022
@ramiro050 @dellis23
Replace linear transformation with low and high in test inputs (#…
77de6d3 
…1485)

This commit replaces test inputs that were being linearly transformed
by multiplying and adding/subtracting to the input tensor with inputs
that use the `low` and `high` keyword arguments instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivekkhandelwal1 vivekkhandelwal1 vivekkhandelwal1 approved these changes

@qedawkins qedawkins Awaiting requested review from qedawkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramiro050 @vivekkhandelwal1