Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bazel] Update to 7.x #86297

Merged
merged 1 commit into from
Mar 22, 2024
Merged

[bazel] Update to 7.x #86297

merged 1 commit into from
Mar 22, 2024

Conversation

keith
Copy link
Member

@keith keith commented Mar 22, 2024

No description provided.

@keith keith requested a review from rupprecht as a code owner March 22, 2024 15:48
Copy link
Member

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I'll also take another look at #55924.

@keith keith merged commit ab8ace3 into llvm:main Mar 22, 2024
5 checks passed
@keith keith deleted the ks/bazel-update-to-7.x branch March 22, 2024 16:05
@durin42
Copy link
Contributor

durin42 commented Mar 22, 2024

This seems to be pretty broken (included both links because for some reason the first run including this change truncated the output) on the buildkite for bazel - I can reproduce locally with USE_BAZEL_VERSION=7.1.1 bazelisk build --config=ci --config=generic_clang @llvm-project//llvm/unittests:SupportTests which fails like this:

ERROR: [...]llvm-project/llvm/unittests/BUILD.bazel:633:8: Compiling llvm/unittests/Support/DebugTest.cpp failed: undeclared inclusion(s) in rule '@@llvm-project//llvm/unittests:SupportTests':
this rule is missing dependency declarations for the following files included by 'llvm/unittests/Support/DebugTest.cpp':
  'bazel-out/k8-fastbuild/bin/external/llvm-project/llvm/Demangle.cppmap'
  'bazel-out/k8-fastbuild/bin/external/llvm_zlib/zlib.cppmap'
  'bazel-out/k8-fastbuild/bin/external/llvm_zstd/zstd.cppmap'
  'bazel-out/k8-fastbuild/bin/external/llvm-project/llvm/BitstreamReader.cppmap'
[elided many more cppmap lines]

I don't know enough bazel to be of use here, but it seems like there must be a discrepancy in a rule implementation somehow?

keith added a commit to keith/llvm-project that referenced this pull request Mar 22, 2024
keith added a commit that referenced this pull request Mar 22, 2024
@keith
Copy link
Member Author

keith commented Mar 22, 2024

thanks for linking, merged a revert here to unblock #86325

do you know if there is a way I can run those CI jobs on my change? on my linux x86 machine with your command I don't see the same issue

@keith keith mentioned this pull request Mar 22, 2024
@keith
Copy link
Member Author

keith commented Mar 22, 2024

working on the reland + a fix here #86326

@durin42
Copy link
Contributor

durin42 commented Mar 22, 2024

thanks for linking, merged a revert here to unblock #86325

do you know if there is a way I can run those CI jobs on my change? on my linux x86 machine with your command I don't see the same issue

I wish I did! It took some futzing to get it to reproduce for me, and while I thought the --config=ci was the magic I'm not entirely sure it was. I'll ask around if anyone can provide advice on a better way to reproduce. :/

chencha3 pushed a commit to chencha3/llvm-project that referenced this pull request Mar 23, 2024
chencha3 pushed a commit to chencha3/llvm-project that referenced this pull request Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants