[TOSA] Handle dialect check more efficiently #120960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-mlir Author: Luke Hutton (lhutton1) ChangesAfter a suggestion in #120205, this commit adjusts a dialect check that runs per op to be more efficient. Full diff: https://github.com/llvm/llvm-project/pull/120960.diff 1 Files Affected:
diff --git a/mlir/lib/Dialect/Tosa/Transforms/TosaValidation.cpp b/mlir/lib/Dialect/Tosa/Transforms/TosaValidation.cpp
index 6fd671051362ca..c58f8927217940 100644
--- a/mlir/lib/Dialect/Tosa/Transforms/TosaValidation.cpp
+++ b/mlir/lib/Dialect/Tosa/Transforms/TosaValidation.cpp
@@ -542,9 +542,13 @@ bool TosaValidation::isValidElementType(Type type) {
void TosaValidation::runOnOperation() {
configLevelAndProfile();
+
+ TosaDialect* tosaDialect = getContext().getLoadedDialect<TosaDialect>();
+ if (!tosaDialect)
+ return;
+
getOperation().walk([&](Operation *op) {
- if (!op->getDialect() ||
- op->getDialect()->getNamespace() != TosaDialect::getDialectNamespace())
+ if (op->getDialect() != tosaDialect)
return;
for (Value operand : op->getOperands()) {
|
|
@llvm/pr-subscribers-mlir-tosa Author: Luke Hutton (lhutton1) ChangesAfter a suggestion in #120205, this commit adjusts a dialect check that runs per op to be more efficient. Full diff: https://github.com/llvm/llvm-project/pull/120960.diff 1 Files Affected:
diff --git a/mlir/lib/Dialect/Tosa/Transforms/TosaValidation.cpp b/mlir/lib/Dialect/Tosa/Transforms/TosaValidation.cpp
index 6fd671051362ca..c58f8927217940 100644
--- a/mlir/lib/Dialect/Tosa/Transforms/TosaValidation.cpp
+++ b/mlir/lib/Dialect/Tosa/Transforms/TosaValidation.cpp
@@ -542,9 +542,13 @@ bool TosaValidation::isValidElementType(Type type) {
void TosaValidation::runOnOperation() {
configLevelAndProfile();
+
+ TosaDialect* tosaDialect = getContext().getLoadedDialect<TosaDialect>();
+ if (!tosaDialect)
+ return;
+
getOperation().walk([&](Operation *op) {
- if (!op->getDialect() ||
- op->getDialect()->getNamespace() != TosaDialect::getDialectNamespace())
+ if (op->getDialect() != tosaDialect)
return;
for (Value operand : op->getOperands()) {
|
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
After a suggestion in llvm#120205, this commit adjusts a dialect check that runs per op to be more efficient. Signed-off-by: Luke Hutton <luke.hutton@arm.com> Change-Id: I137ec8e1fd73dc2de0b211e1ff38cb128e99a671
cee2f4a to
185f775
Compare
qiaojbao
pushed a commit
to GPUOpen-Drivers/llvm-project
that referenced
this pull request
Feb 7, 2025
Local branch amd-gfx d1314f0 Merged main:998bdae7f5ce into amd-gfx:1f2edbe54368 Remote branch main 39e93ee [TOSA] Handle dialect check more efficiently (llvm#120960)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a suggestion in #120205, this commit adjusts a dialect check that runs per op to be more efficient.