[msan] Enable and update neon_vst_float test case #100435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'ptr %a' renamed to 'ptr %p' because update_test_checks.py is case-insensitive and was unexpectedly aliasing the %A and %a in the expected output ('<1 x double> [[A]], <1 x double> [[B]], ptr [[A]]').
The sample output for st1x{2,3,4} was previously accidentally generated using a prototype version of MSan rather than trunk; these instructions are not yet instrumented.
This patch also changes the comment on how the test case was generated, because '; | sed -r 's/^\/\/ CHECK:[ ]*//'' was being interpeted by FileCheck to be a CHECK: command.
This enables the neon_vst_float test case (llvm#100210). Although MSan does not yet generate useful IR, since opt is run with -disable-verify, the test case should still run successfully. This patch also makes minor fixes to the test case: - 'ptr %a' is renamed to 'ptr %p' because update_test_checks.py is case-insensitive, and was unexpectedly aliasing the %A and %a in the expected output ('<1 x double> [[A]], <1 x double> [[B]], ptr [[A]]'). - The sample output for st1x{2,3,4} was previously accidentally generated using a prototype version of MSan rather than trunk; these instructions are not yet instrumented. - Changes the comment on how the test case was generated, because '; | sed -r 's/^\/\/ CHECK:[ ]*//'' was being interpreted by FileCheck to be a CHECK: command.
vitalybuka
approved these changes
Jul 25, 2024
yuxuanchen1997
pushed a commit
that referenced
this pull request
Jul 25, 2024
Summary: This enables the neon_vst_float test case (#100210). Although MSan does not yet generate useful IR, since opt is run with -disable-verify, the test case should still run successfully. This patch also makes minor fixes to the test case: - 'ptr %a' is renamed to 'ptr %p' because update_test_checks.py is case-insensitive, and was unexpectedly aliasing the %A and %a in the expected output ('<1 x double> [[A]], <1 x double> [[B]], ptr [[A]]'). - The sample output for st1x{2,3,4} was previously accidentally generated using a prototype version of MSan rather than trunk; these instructions are not yet instrumented. - Changes the comment on how the test case was generated, because '; | sed -r 's/^\/\/ CHECK:[ ]*//'' was being interpreted by FileCheck to be a CHECK: command. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60250746
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the neon_vst_float test case (#100210). Although MSan does not yet generate useful IR, since opt is run with -disable-verify, the test case should still run successfully.
This patch also makes minor fixes to the test case: