Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Update wheels we build in CI/CD. #8051

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

mikeurbach
Copy link
Contributor

This removes MacOS, which has been failing, and no one seems to care about anyway. This also adds a newer Python 3.13 wheel for a more modern Python version. I have not yet removed the Python 3.8 wheel, but that is EOL, and we can consider removing that in a follow up.

@mikeurbach mikeurbach requested a review from teqdruid as a code owner January 9, 2025 20:21
@mikeurbach mikeurbach requested review from leonardt and teqdruid and removed request for teqdruid January 9, 2025 20:21
@mikeurbach
Copy link
Contributor Author

@teqdruid do you care about Python 3.8 wheels for the core bindings package? I might remove those as well.

@mikeurbach
Copy link
Contributor Author

Kicked off a sanity test wheel build here: https://github.com/llvm/circt/actions/runs/12697878099.

@teqdruid
Copy link
Contributor

teqdruid commented Jan 9, 2025

@teqdruid do you care about Python 3.8 wheels for the core bindings package? I might remove those as well.

I don't use the core bindings package, so no.

I do, however, care about being able to build the Python 3.8 bindings as PyCDE continues to support 3.8.

@mikeurbach mikeurbach force-pushed the mikeurbach/python-update-wheels branch from d39ea2f to 21129d6 Compare January 9, 2025 20:47
@mikeurbach
Copy link
Contributor Author

Thanks, makes sense. I don't think anyone is doing anything that won't be compatible with Python 3.8. We can keep using the lowest common denominator Python features (e.g., avoid the fancier new generics syntax in Python 3.13). If no one cares about this version of the core bindings wheels, I'll remove that in this PR.

This removes MacOS, which has been failing, and no one seems to care
about anyway. This also removes the Python 3.8 wheel on Linux, since
Python 3.8 is now EOL. Finally, this adds a newer Python 3.13 wheel
for a more modern Python version.

This also updates the cibuildwheel version we use to the newest
release, which has full Python 3.13 support. There should be no
breaking changes, but cibuildwheel will warn that the next major
release requires Python 3.11 or newer.
@mikeurbach
Copy link
Contributor Author

Wheel build is passing for Python 3.13 with the cibuildwheel update. I'll go ahead and merge this now.

@mikeurbach mikeurbach merged commit af7d6c2 into main Jan 9, 2025
7 checks passed
@mikeurbach mikeurbach deleted the mikeurbach/python-update-wheels branch January 9, 2025 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants